Page MenuHomeDevCentral
Differential D3465

Import Postman collection for Notifications Delivery API
Needs ReviewPublic
Actions

Authored by dereckson on Wed, Sep 25, 21:41.

Details

Reviewers
DorianWinty
inidal
Maniphest Tasks
T2027: Export Postman collection to a Bruno repository
Commits
rBRUNOebf3e0876dae: Import Postman collection for Notifications Delivery API
Summary

Ref T2027

Diff Detail

Event Timeline

dereckson requested review of this revision.Wed, Sep 25, 21:41
dereckson created this revision.
Harbormaster completed remote builds in B5510: Diff 8931.Wed, Sep 25, 21:41
dereckson updated this revision to Diff 8932.Wed, Sep 25, 21:57

Allow filenames to contain spaces

Collections folder are collections names.
As such, filenames can contain spaces.

This is a follow-up for 14472c096b1d.

Harbormaster completed remote builds in B5511: Diff 8932.Wed, Sep 25, 21:57
dereckson updated this revision to Diff 8933.Wed, Sep 25, 21:59

Only Arc linter fix, not the Delivery API collection.

Harbormaster completed remote builds in B5512: Diff 8933.Wed, Sep 25, 21:59
dereckson accepted this revision.Wed, Sep 25, 21:59
This revision is now accepted and ready to land.Wed, Sep 25, 21:59
Closed by commit rBRUNOebf3e0876dae: Import Postman collection for Notifications Delivery API (authored by dereckson). · Explain WhyWed, Sep 25, 22:00
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rBRUNOebf3e0876dae: Import Postman collection for Notifications Delivery API.
dereckson reopened this revision.Wed, Sep 25, 22:10
This revision is now accepted and ready to land.Wed, Sep 25, 22:10
dereckson updated this revision to Diff 8938.Wed, Sep 25, 22:10

Same player, try again. D3466 was merged by error with this one.

Harbormaster completed remote builds in B5515: Diff 8938.Wed, Sep 25, 22:10
dereckson removed a reviewer: dereckson.Wed, Sep 25, 22:11
This revision now requires review to proceed.Wed, Sep 25, 22:11
inidal requested changes to this revision.Thu, Sep 26, 02:19

All good, just consider using environment variables for the base URL and API keys and you're good to go. Good job! 👍🏻

nasqueron/notifications/Delivery API/get.bru
9

Possible use of environment variables

nasqueron/notifications/Delivery API/register_consumer -404-.bru
9

Possible use of environment variables

20

api-key is hardcoded in 3 files, possible use of environment variable?

nasqueron/notifications/Delivery API/register_consumer -default-.bru
9

Possible use of environment variables

20

api-key is hardcoded in 3 files, possible use of environment variable?

nasqueron/notifications/Delivery API/register_consumer.bru
9

Possible use of environment variables

20

api-key is hardcoded in 3 files, possible use of environment variable?

This revision now requires changes to proceed.Thu, Sep 26, 02:19
dereckson updated this revision to Diff 8941.Thu, Sep 26, 17:29

Indeed, we can save an environment per collection, that makes sense to use it.

Harbormaster completed remote builds in B5518: Diff 8941.Thu, Sep 26, 17:29

Revision Contents
Changeset List

Diff 8931

View Options

nasqueron/notifications/Delivery API/200 ALIVE.bru

Loading...
View Options

nasqueron/notifications/Delivery API/bruno.json

Loading...
View Options

nasqueron/notifications/Delivery API/collection.bru

Loading...
View Options

nasqueron/notifications/Delivery API/get -base64-.bru

Loading...
View Options

nasqueron/notifications/Delivery API/get -invalid format-.bru

Loading...
View Options

nasqueron/notifications/Delivery API/get.bru

Loading...
View Options

nasqueron/notifications/Delivery API/register_consumer -404-.bru

Loading...
View Options

nasqueron/notifications/Delivery API/register_consumer -default-.bru

Loading...
View Options

nasqueron/notifications/Delivery API/register_consumer.bru

Loading...
View Options

nasqueron/notifications/Delivery API/unregister_consumer.bru

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator