Differential D3465

Import Postman collection for Notifications Delivery API
Needs ReviewPublic
Actions

Authored by dereckson on Wed, Sep 25, 21:41.

Tags

None

Referenced Files

None

Subscribers

None

Details

Reviewers

DorianWinty
inidal

Maniphest Tasks

T2027: Export Postman collection to a Bruno repository

Commits

rBRUNOebf3e0876dae: Import Postman collection for Notifications Delivery API

Summary

Diff Detail

Repository

rBRUNO API collections for Bruno

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Wed, Sep 25, 21:41

dereckson created this revision.

Harbormaster completed remote builds in B5510: Diff 8931.Wed, Sep 25, 21:41

Allow filenames to contain spaces

Collections folder are collections names.
As such, filenames can contain spaces.

This is a follow-up for 14472c096b1d.

Harbormaster completed remote builds in B5511: Diff 8932.Wed, Sep 25, 21:57

Only Arc linter fix, not the Delivery API collection.

Harbormaster completed remote builds in B5512: Diff 8933.Wed, Sep 25, 21:59

dereckson accepted this revision.Wed, Sep 25, 21:59

This revision is now accepted and ready to land.Wed, Sep 25, 21:59

Closed by commit rBRUNOebf3e0876dae: Import Postman collection for Notifications Delivery API (authored by dereckson). · Explain WhyWed, Sep 25, 22:00

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rBRUNOebf3e0876dae: Import Postman collection for Notifications Delivery API.

dereckson reopened this revision.Wed, Sep 25, 22:10

This revision is now accepted and ready to land.Wed, Sep 25, 22:10

Same player, try again. D3466 was merged by error with this one.

Harbormaster completed remote builds in B5515: Diff 8938.Wed, Sep 25, 22:10

dereckson removed a reviewer: dereckson.Wed, Sep 25, 22:11

This revision now requires review to proceed.Wed, Sep 25, 22:11

All good, just consider using environment variables for the base URL and API keys and you're good to go. Good job! 👍🏻

nasqueron/notifications/Delivery API/get.bru
8 ↗	(On Diff #8938)	Possible use of environment variables
nasqueron/notifications/Delivery API/register_consumer -404-.bru
8 ↗	(On Diff #8938)	Possible use of environment variables
19 ↗	(On Diff #8938)	api-key is hardcoded in 3 files, possible use of environment variable?
nasqueron/notifications/Delivery API/register_consumer -default-.bru
8 ↗	(On Diff #8938)	Possible use of environment variables
19 ↗	(On Diff #8938)	api-key is hardcoded in 3 files, possible use of environment variable?
nasqueron/notifications/Delivery API/register_consumer.bru
8 ↗	(On Diff #8938)	Possible use of environment variables
19 ↗	(On Diff #8938)	api-key is hardcoded in 3 files, possible use of environment variable?

This revision now requires changes to proceed.Thu, Sep 26, 02:19

Indeed, we can save an environment per collection, that makes sense to use it.

Harbormaster completed remote builds in B5518: Diff 8941.Thu, Sep 26, 17:29

Revision Contents
Changeset List

Path

Size

3 lines

Diff 8934

.arclint

Loading...