Differential D3465

Import Postman collection for Notifications Delivery API
ClosedPublic
Actions

Authored by dereckson on Sep 25 2024, 21:41.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 19, 21:51

	Unknown Object (File)
	Mon, Nov 18, 05:22

	Unknown Object (File)
	Sun, Nov 17, 21:59

	Unknown Object (File)
	Sat, Nov 16, 01:43

	Unknown Object (File)
	Sat, Nov 16, 01:13

	Unknown Object (File)
	Fri, Nov 15, 04:42

	Unknown Object (File)
	Fri, Nov 15, 04:35

	Unknown Object (File)
	Fri, Nov 15, 04:24

View All 84 Files

Subscribers

None

Details

Reviewers

DorianWinty
inidal

Maniphest Tasks

T2027: Export Postman collection to a Bruno repository

Commits

rBRUNO4e1e90d2236c: Import Postman collection for Notifications Delivery API
rBRUNOebf3e0876dae: Import Postman collection for Notifications Delivery API

Summary

Diff Detail

Repository

rBRUNO API collections for Bruno

Lint

Lint Passed

Unit

No Test Coverage

Branch

allow-spaces-in-filenames

Build Status

Buildable 5512
Build 5793: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Sep 25 2024, 21:41

dereckson created this revision.

Harbormaster completed remote builds in B5510: Diff 8931.Sep 25 2024, 21:41

Allow filenames to contain spaces

Collections folder are collections names.
As such, filenames can contain spaces.

This is a follow-up for 14472c096b1d.

Harbormaster completed remote builds in B5511: Diff 8932.Sep 25 2024, 21:57

Only Arc linter fix, not the Delivery API collection.

Harbormaster completed remote builds in B5512: Diff 8933.Sep 25 2024, 21:59

dereckson accepted this revision.Sep 25 2024, 21:59

This revision is now accepted and ready to land.Sep 25 2024, 21:59

Closed by commit rBRUNOebf3e0876dae: Import Postman collection for Notifications Delivery API (authored by dereckson). · Explain WhySep 25 2024, 22:00

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rBRUNOebf3e0876dae: Import Postman collection for Notifications Delivery API.

dereckson reopened this revision.Sep 25 2024, 22:10

This revision is now accepted and ready to land.Sep 25 2024, 22:10

Same player, try again. D3466 was merged by error with this one.

Harbormaster completed remote builds in B5515: Diff 8938.Sep 25 2024, 22:10

dereckson removed a reviewer: dereckson.Sep 25 2024, 22:11

This revision now requires review to proceed.Sep 25 2024, 22:11

All good, just consider using environment variables for the base URL and API keys and you're good to go. Good job! 👍🏻

nasqueron/notifications/Delivery API/get.bru
8 ↗	(On Diff #8938)	Possible use of environment variables
nasqueron/notifications/Delivery API/register_consumer -404-.bru
8 ↗	(On Diff #8938)	Possible use of environment variables
19 ↗	(On Diff #8938)	api-key is hardcoded in 3 files, possible use of environment variable?
nasqueron/notifications/Delivery API/register_consumer -default-.bru
8 ↗	(On Diff #8938)	Possible use of environment variables
19 ↗	(On Diff #8938)	api-key is hardcoded in 3 files, possible use of environment variable?
nasqueron/notifications/Delivery API/register_consumer.bru
8 ↗	(On Diff #8938)	Possible use of environment variables
19 ↗	(On Diff #8938)	api-key is hardcoded in 3 files, possible use of environment variable?

This revision now requires changes to proceed.Sep 26 2024, 02:19

Indeed, we can save an environment per collection, that makes sense to use it.

Harbormaster completed remote builds in B5518: Diff 8941.Sep 26 2024, 17:29

inidal accepted this revision.Sep 30 2024, 09:59

This revision is now accepted and ready to land.Sep 30 2024, 09:59

Closed by commit rBRUNO4e1e90d2236c: Import Postman collection for Notifications Delivery API (authored by dereckson). · Explain WhyOct 1 2024, 01:02

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rBRUNO4e1e90d2236c: Import Postman collection for Notifications Delivery API.

Revision Contents
Changeset List

Path

Size

3 lines

Diff 8933

.arclint

Loading...