Build is green https://ci.nasqueron.org/job/test-notifications-phab/156/ for more details.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Aug 19 2016
Aug 19 2016
Better code documentation
In D617#9435, @dereckson wrote:There is an issue in logic code too.
[ErrorException] Undefined property: stdClass::$repository
Payload was already a notification, not a DockerHub payload.
More tests.
Build is green https://ci.nasqueron.org/job/test-notifications-phab/155/ for more details.
There is an issue in logic code too.
dereckson retitled D617: Add notifications:payload command from to Add notifications:payload command.
Clean commented out code
dereckson closed D526: Clean commented out code by committing rDWD92ff7cf74e2f: Clean commented out code.
Avoid shadow variable name
dereckson closed D569: Avoid shadow variable name by committing rDWDa991d5d09084: Avoid shadow variable name.
GitHub <noreply@github.com> committed rDPHAB749c8a9155de: Merge 48b2ffbf1481dbab46100e6d5bf9999ec34826df into… (authored by Aaron Eppert <aeppert@gmail.com>).
Merge 48b2ffbf1481dbab46100e6d5bf9999ec34826df into…
Sandlayth committed rDPHAB9ff2cc7b5e0d: Explain why mysql.host is written in hard (authored by Sandlayth).
Explain why mysql.host is written in hard
Aug 18 2016
Aug 18 2016
dereckson added inline comments to rDPHAB82a577551716: Merge 48b2ffbf1481dbab46100e6d5bf9999ec34826df into….
GitHub <noreply@github.com> committed rDPHAB82a577551716: Merge 48b2ffbf1481dbab46100e6d5bf9999ec34826df into… (authored by Aaron Eppert <aeppert@gmail.com>).
Merge 48b2ffbf1481dbab46100e6d5bf9999ec34826df into…
dereckson committed rDPHABf1d02969c688: Improve code readability: 8 Mb, restart operation (authored by xcombelle).
Improve code readability: 8 Mb, restart operation
dereckson closed D602: Improve code readability: 8 Mb, restart operation by committing rDPHABf1d02969c688: Improve code readability: 8 Mb, restart operation (authored by xcombelle).
Rebased against master.
That would be set -e
Sandlayth retitled D615: Explain why mysql.host is written in hard from Explaining why mysql.host is written in hard. to Explain why mysql.host is written in hard.
There is no demonstrated advantage to use that, the json parsing issue in D347 was a false issue.
dereckson awarded D615: Explain why mysql.host is written in hard a Piece of Eight token.
dereckson committed rGROVEb3ae033adfc2: Define explicitly method visibility (authored by dereckson).
Define explicitly method visibility
Build is green https://ci.nasqueron.org/job/test-auth-grove-phab/4/ for more details.
dereckson retitled D616: Define explicitly method visibility from to Define explicitly method visibility.
According Bradipo from Freenode tcl channel, parsing is okay (and produces a correct dict) with json 1.3.3.
JSON makes a lot of sense, there is no need to parse twice a JSON payload, once for our notification format, once for the source payload.
Sandlayth retitled D615: Explain why mysql.host is written in hard from to Explaining why mysql.host is written in hard..
Aug 17 2016
Aug 17 2016
Add quotes to command arguments
Sandlayth closed D603: Add quotes to command arguments by committing rDPHABc0dec7d81d77: Add quotes to command arguments (authored by xcombelle).
dereckson committed rKBROKER545d2db54f4c: Explicitely set visibility to public methods (authored by dereckson).
Explicitely set visibility to public methods
dereckson retitled D614: Explicitely set visibility to public methods from to Explicitely set visibility to public methods.
According Bradipo from TCL, parsing is okay (and produces a correct dict) with json 1.3.3.
According Bradipo from TCL, parsing is okay (and produces a correct dict) with json 1.3.3.
dereckson added a project to T984: Pick a format for Notifications::$rawContent property: architecture.
Currently, D347 is, as far as I know, the first piece of code consuming raw content.
Aug 16 2016
Aug 16 2016
The error occurs at the JSON parser level, invoked by json::json2dict $payload in get_image_from_docker_payload proc.
dereckson moved T983: CLI command to get a notification payload from a service payload from Backlog to Working on on the Notifications center board.
dereckson retitled D604: only touch .initialized on success of service restart from only touch .initialized on succes of service restart to only touch .initialized on success of service restart.
To fail on error is probably a good idea to avoid to say .initialized when an error occurs
Rebased against master.
Sandlayth renamed T826: Create a systemd timer to renew letsencrypt certificat on Dwellers from Create a systemd timer to renew letsecrypt certificat on Dwellers to Create a systemd timer to renew letsencrypt certificat on Dwellers.
Build is green https://ci.nasqueron.org/job/test-notifications-phab/154/ for more details.
More tests
dereckson moved T981: Define a policy for acceptable vhosts on Eglide from Backlog to Needs Review / Blocked / Waiting on the User-Dereckson board.
Aug 15 2016
Aug 15 2016
Build is green https://ci.nasqueron.org/job/test-notifications-phab/153/ for more details.
Fix issue when status is absent, like for job started notifications.
Publish JUnit XML report
dereckson closed D613: Publish JUnit XML report by committing rTESTSPRODENVc78598d85029: Publish JUnit XML report.
Ask Jenkins to publish artefacts in build/
dereckson updated the task description for T980: Set 2001:470:1f13:896::15 to server7.radarbolmong.com for Eglide.
dereckson renamed T980: Set 2001:470:1f13:896::15 to server7.radarbolmong.com for Eglide from Set 2001:470:1f13:896::15 to ns1.radarbolmong.com for Eglide to Set 2001:470:1f13:896::15 to server7.radarbolmong.com for Eglide.
Build is green https://ci.nasqueron.org/job/test-notifications-phab/152/ for more details.
[2016-08-15 19:22:01] local.ERROR: exception 'ErrorException' with message 'Undefined property: stdClass::$status' in /home/ubuntu/workspace/notifications/app/Notifications/JenkinsNotification.php:48
Stack trace:
#0 /home/ubuntu/workspace/notifications/app/Notifications/JenkinsNotification.php(48): Illuminate\Foundation\Bootstrap\HandleExceptions->handleError(8, 'Undefined prope...', '/home/ubuntu/wo...', 48, Array)
#1 /home/ubuntu/workspace/notifications/app/Notifications/JenkinsNotification.php(23): Nasqueron\Notifications\Notifications\JenkinsNotification->getText()
#2 /home/ubuntu/workspace/notifications/app/Jobs/FireJenkinsNotification.php(52): Nasqueron\Notifications\Notifications\JenkinsNotification->__construct('Nasqueron', Object(stdClass))
#3 /home/ubuntu/workspace/notifications/app/Jobs/FireJenkinsNotification.php(38): Nasqueron\Notifications\Jobs\FireJenkinsNotification->createNotification()
#4 /home/ubuntu/workspace/notifications/app/Listeners/NotificationListener.php(61): Nasqueron\Notifications\Jobs\FireJenkinsNotification->handle()
#5 [internal function]: Nasqueron\Notifications\Listeners\NotificationListener->onJenkinsPayload(Object(Nasqueron\Notifications\Events\JenkinsPayloadEvent))
#6 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php(348): call_user_func_array(Array, Array)
#7 [internal function]: Illuminate\Events\Dispatcher->Illuminate\Events\{closure}(Object(Nasqueron\Notifications\Events\JenkinsPayloadEvent))
#8 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Events/Dispatcher.php(221): call_user_func_array(Object(Closure), Array)
#9 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php(217): Illuminate\Events\Dispatcher->fire(Object(Nasqueron\Notifications\Events\JenkinsPayloadEvent))
#10 /home/ubuntu/workspace/notifications/app/Http/Controllers/Gate/JenkinsGateController.php(84): Illuminate\Support\Facades\Facade::__callStatic('fire', Array)
#11 /home/ubuntu/workspace/notifications/app/Http/Controllers/Gate/JenkinsGateController.php(84): Illuminate\Support\Facades\Event::fire(Object(Nasqueron\Notifications\Events\JenkinsPayloadEvent))
#12 /home/ubuntu/workspace/notifications/app/Http/Controllers/Gate/JenkinsGateController.php(58): Nasqueron\Notifications\Http\Controllers\Gate\JenkinsGateController->onPayload()
#13 [internal function]: Nasqueron\Notifications\Http\Controllers\Gate\JenkinsGateController->onPost('Nasqueron')
#14 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Routing/Controller.php(80): call_user_func_array(Array, Array)
#15 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php(146): Illuminate\Routing\Controller->callAction('onPost', Array)
#16 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php(94): Illuminate\Routing\ControllerDispatcher->call(Object(Nasqueron\Notifications\Http\Controllers\Gate\JenkinsGateController), Object(Illuminate\Routing\Route), 'onPost')
#17 [internal function]: Illuminate\Routing\ControllerDispatcher->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#18 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(52): call_user_func(Object(Closure), Object(Illuminate\Http\Request))
#19 [internal function]: Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#20 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(103): call_user_func(Object(Closure), Object(Illuminate\Http\Request))
#21 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php(96): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#22 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php(54): Illuminate\Routing\ControllerDispatcher->callWithinStack(Object(Nasqueron\Notifications\Http\Controllers\Gate\JenkinsGateController), Object(Illuminate\Routing\Route), Object(Illuminate\Http\Request), 'onPost')
#23 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Routing/Route.php(174): Illuminate\Routing\ControllerDispatcher->dispatch(Object(Illuminate\Routing\Route), Object(Illuminate\Http\Request), 'Nasqueron\\Notif...', 'onPost')
#24 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Routing/Route.php(140): Illuminate\Routing\Route->runController(Object(Illuminate\Http\Request))
#25 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Routing/Router.php(724): Illuminate\Routing\Route->run(Object(Illuminate\Http\Request))
#26 [internal function]: Illuminate\Routing\Router->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#27 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(52): call_user_func(Object(Closure), Object(Illuminate\Http\Request))
#28 [internal function]: Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#29 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(103): call_user_func(Object(Closure), Object(Illuminate\Http\Request))
#30 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Routing/Router.php(726): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#31 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Routing/Router.php(699): Illuminate\Routing\Router->runRouteWithinStack(Object(Illuminate\Routing\Route), Object(Illuminate\Http\Request))
#32 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Routing/Router.php(675): Illuminate\Routing\Router->dispatchToRoute(Object(Illuminate\Http\Request))
#33 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(246): Illuminate\Routing\Router->dispatch(Object(Illuminate\Http\Request))
#34 [internal function]: Illuminate\Foundation\Http\Kernel->Illuminate\Foundation\Http\{closure}(Object(Illuminate\Http\Request))
#35 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(52): call_user_func(Object(Closure), Object(Illuminate\Http\Request))
#36 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/VerifyCsrfToken.php(64): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#37 [internal function]: Illuminate\Foundation\Http\Middleware\VerifyCsrfToken->handle(Object(Illuminate\Http\Request), Object(Closure))
#38 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(136): call_user_func_array(Array, Array)
#39 [internal function]: Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#40 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(32): call_user_func(Object(Closure), Object(Illuminate\Http\Request))
#41 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/View/Middleware/ShareErrorsFromSession.php(49): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#42 [internal function]: Illuminate\View\Middleware\ShareErrorsFromSession->handle(Object(Illuminate\Http\Request), Object(Closure))
#43 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(136): call_user_func_array(Array, Array)
#44 [internal function]: Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#45 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(32): call_user_func(Object(Closure), Object(Illuminate\Http\Request))
#46 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php(64): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#47 [internal function]: Illuminate\Session\Middleware\StartSession->handle(Object(Illuminate\Http\Request), Object(Closure))
#48 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(136): call_user_func_array(Array, Array)
#49 [internal function]: Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#50 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(32): call_user_func(Object(Closure), Object(Illuminate\Http\Request))
#51 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/AddQueuedCookiesToResponse.php(37): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#52 [internal function]: Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse->handle(Object(Illuminate\Http\Request), Object(Closure))
#53 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(136): call_user_func_array(Array, Array)
#54 [internal function]: Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#55 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(32): call_user_func(Object(Closure), Object(Illuminate\Http\Request))
#56 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php(59): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#57 [internal function]: Illuminate\Cookie\Middleware\EncryptCookies->handle(Object(Illuminate\Http\Request), Object(Closure))
#58 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(136): call_user_func_array(Array, Array)
#59 [internal function]: Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#60 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(32): call_user_func(Object(Closure), Object(Illuminate\Http\Request))
#61 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/CheckForMaintenanceMode.php(44): Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#62 [internal function]: Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode->handle(Object(Illuminate\Http\Request), Object(Closure))
#63 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(136): call_user_func_array(Array, Array)
#64 [internal function]: Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#65 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(32): call_user_func(Object(Closure), Object(Illuminate\Http\Request))
#66 [internal function]: Illuminate\Routing\Pipeline->Illuminate\Routing\{closure}(Object(Illuminate\Http\Request))
#67 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(103): call_user_func(Object(Closure), Object(Illuminate\Http\Request))
#68 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(132): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#69 /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(99): Illuminate\Foundation\Http\Kernel->sendRequestThroughRouter(Object(Illuminate\Http\Request))
#70 /home/ubuntu/workspace/notifications/public/index.php(54): Illuminate\Foundation\Http\Kernel->handle(Object(Illuminate\Http\Request))
#71 {main}dereckson retitled D612: Add support for Jenkins notification plug-in from to Add support for Jenkins notification plug-in.
The payload contains a scm section.
An example of notifications for one of our Jenkins job is at P212.
dereckson moved T953: Handle Jenkins notification plugin payloads from New services to Working on on the Notifications center board.
Log some handled exceptions
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator