Fixed in D227.

• DockerHubGateController covered at 100%
• More than 50% of the application methods are now covered by tests

New line at EOF

Concerns addressed by D220 / rNOTIF46a71ea7b2f3.

This commit introduced dead code, as the class Log is declared but never used.

Test coverage. This change brings full coverage for GateController class.

Code documentation restored.

+1 line covered, +1 method fully covered.

Upstream not interested by the change, but provides a simpler solution.

In D197#3104, @dereckson wrote:

We need to mock the broker.

Code to mock

Broker::setExchangeTarget($this->target)
    ->routeTo($this->routingKey)
    ->sendMessage($this->message);

Mock proposal

$mock = Mockery('Keruald\Broker\AMQPBroker');

$mock->shouldReceive('setExchangeTarget'); // TODO: return $this, not null
$mock->shouldReceive('routeTo');
$mock->shouldReceive('sendMessage');

$this->app->instance('broker', $mock);

Reference: http://docs.mockery.io/en/latest/reference/demeter_chains.html

Added PayloadFullTest::testInvalidSignature to hunt 403