I don't want to add options if we aren't going to use it, but it's fairly ok to move the date format in config, as a strftime if there are divergent opinions on this one.

Sample payload in P236.

If we don't use it and nobody else does, we can remove the feature instead making it optional.

In T1089#13198, @dereckson wrote:

I can repro the regression with the following test:

tests/Jobs/NotifyNewCommitsToDiffusionTest.php

public function testJobWhenThereIsNoPhabricatorInstanceForTheProject () {
    $this->mockJob("not-existing-project");
    $this->job->handle();
}

protected function mockJob(string $project = "acme") {
    $this->job = new NotifyNewCommitsToDiffusion(
        $project,
        "ssh://acme/k2.git"
    );
}

This produces the following stack trace:

Nasqueron\Notifications\Tests\Jobs\NotifyNewCommitsToDiffusionTest::testJobWhenThereIsNoPhabricatorInstanceForTheProject
RuntimeException: No credentials for Phabricator project not-existing-project.

/app/notifications/app/Phabricator/PhabricatorAPI.php:67
/app/notifications/app/Phabricator/PhabricatorAPIFactory.php:26
/app/notifications/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php:217
/app/notifications/app/Jobs/NotifyNewCommitsToDiffusion.php:146
/app/notifications/app/Jobs/NotifyNewCommitsToDiffusion.php:136
/app/notifications/app/Jobs/NotifyNewCommitsToDiffusion.php:75
/app/notifications/tests/Jobs/NotifyNewCommitsToDiffusionTest.php:37

I can repro the regression with the following test:

http://laravel-recipes.com/recipes/60/optimizing-the-framework-for-better-performance notes a need to use use statements instead of absolute \namespace\class notation.

We don't use BitBucket anymore for rVIPERSERV. It has been converted to Git as rVIPER.

Sprint status — Notifications center — No, this is not a magic elixir, this is a fir distillate

This JSON document is written by hand as test result for this output:

Makefile should be RUN_DEPENDS= ${PYTHON_SITELIBDIR}/pika/amqp_object.py:devel/py-pika.

[ Set status as Resolved, as the original issue was a correct issue to solve. The fact we can't repro doesn't mean it was invalid at writing time, but the issue was solved, for example by a caching invalidation on Packagist side. ]

Works correctly now.

Can't repro on an empty folder: