Build is green https://ci.nasqueron.org/job/test-notifications-phab/158/ for more details.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/157/ for more details.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/156/ for more details.

Better code documentation

EOL

In D617#9435, @dereckson wrote:

There is an issue in logic code too.

[ErrorException]                           
Undefined property: stdClass::$repository

Payload was already a notification, not a DockerHub payload.

More tests.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/155/ for more details.

There is an issue in logic code too.

Rebased against master.

That would be set -e

There is no demonstrated advantage to use that, the json parsing issue in D347 was a false issue.

Build is green https://ci.nasqueron.org/job/test-auth-grove-phab/4/ for more details.

According Bradipo from Freenode tcl channel, parsing is okay (and produces a correct dict) with json 1.3.3.

JSON makes a lot of sense, there is no need to parse twice a JSON payload, once for our notification format, once for the source payload.

According Bradipo from TCL, parsing is okay (and produces a correct dict) with json 1.3.3.

According Bradipo from TCL, parsing is okay (and produces a correct dict) with json 1.3.3.

Currently, D347 is, as far as I know, the first piece of code consuming raw content.

The error occurs at the JSON parser level, invoked by json::json2dict $payload in get_image_from_docker_payload proc.

To fail on error is probably a good idea to avoid to say .initialized when an error occurs

Rebased against master.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/154/ for more details.

More tests

Build is green https://ci.nasqueron.org/job/test-notifications-phab/153/ for more details.

Fix issue when status is absent, like for job started notifications.

Ask Jenkins to publish artefacts in build/