20:35:55 < missk> yea its login

Draft currently contains:

Update Twitter account. Disable some SCSS components.

Deployed on tools.

Only remove the feature.

Change touches code style too.

If we don't use it and nobody else does, we can remove the feature instead making it optional.

Simplify test, dataProvider

Quick test for no repo but switch to a provider

In T1089#13198, @dereckson wrote:

I can repro the regression with the following test:

tests/Jobs/NotifyNewCommitsToDiffusionTest.php

public function testJobWhenThereIsNoPhabricatorInstanceForTheProject () {
    $this->mockJob("not-existing-project");
    $this->job->handle();
}

protected function mockJob(string $project = "acme") {
    $this->job = new NotifyNewCommitsToDiffusion(
        $project,
        "ssh://acme/k2.git"
    );
}

This produces the following stack trace:

Nasqueron\Notifications\Tests\Jobs\NotifyNewCommitsToDiffusionTest::testJobWhenThereIsNoPhabricatorInstanceForTheProject
RuntimeException: No credentials for Phabricator project not-existing-project.

/app/notifications/app/Phabricator/PhabricatorAPI.php:67
/app/notifications/app/Phabricator/PhabricatorAPIFactory.php:26
/app/notifications/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php:217
/app/notifications/app/Jobs/NotifyNewCommitsToDiffusion.php:146
/app/notifications/app/Jobs/NotifyNewCommitsToDiffusion.php:136
/app/notifications/app/Jobs/NotifyNewCommitsToDiffusion.php:75
/app/notifications/tests/Jobs/NotifyNewCommitsToDiffusionTest.php:37

I can repro the regression with the following test:

Bump keruald/github to 0.2.1 to get rKGHc0e14492852e.