♟ ieli

Remove hardcoded admin token file

Removed hardcoded admin token (thanks to @dereckson)

This revision cannot be accepted.

Fix scrollbar layout shift on all pages

An attempt by @Chenani-MohamedAmine was made on D3992.

I am abandoning this revision.

This code was submitted with an obvious syntax error that would prevent the application from even running. The Vue compiler immediately fails with:

I do not think this is an industry-standard solution. There's gap that's visually visible... Do more research.

In D3989#62108, @Chenani-MohamedAmine wrote:

Added theme configuration in admin Settings tab (mode selector + toggleable checkbox) as requested.

This is out of scope and uses the wrong approach. Please rollback all changes and start over. I've renamed the differential for better clarity.

In D3992#61982, @dereckson wrote:
Per https://cbea.ms/git-commit/ titles of your commit messages should be much shorter.

You can consider a global title then use current info as summary:
[New shorter title]

Add fade transition on route changes.

Fix scrollbar layout shift on IncidentHistory loading state.

In D3989#61878, @ieli wrote:

The implementation uses a boolean dark class on the <html> element. For better flexibility, consider using a data-theme attribute instead of a boolean class. This allows each theme to define its own dark/light variants. Additionally, the toggle button should be hidden for mono themes (themes with only one palette). The useDarkMode composable should expose whether the theme is "toggleable", and the navbar should conditionally render the button based on this. Finally, theme configuration should be available in the admin side - the Settings tab in AdminDashboard.vue would be the appropriate place to add theme selection.

The implementation uses a boolean dark class. Since tools have many themes these days and flexibility is important, consider implementing this as a theme-based system instead of binary dark/light. This would allow adding more themes in the future (e.g., high contrast, brand themes) without architectural changes.

I just noticed that IncidentHistory.test.js tests a view but is in components/__tests__/.
Move the file to views/__tests__/ for consistency.

In D3980#61784, @ieli wrote:

"Past Incidents" section in StatusPage.vue shows 5 most recent. Add a "View all" link to /incidents when incidents are more than 5.

"Past Incidents" section in StatusPage.vue shows 5 most recent. Add a "View all" link to /incidents when incidents are more than 5.

Congrats on your first revision. 👍🏻

I mentioned in D3971 that the requested changes are implemented there.

@Chenani-MohamedAmine I appreciate the effort you’ve put into these logo drafts, but I want to reiterate that I had explicitly asked not to move forward with logo work at this stage. Any design work on the branding or logo requires broader discussion with other members of Nasqueron before proceeding.

I've reviewed your changes. I noticed you created a new differential (D3977) instead of updating the original one for the same task.

Add local review cheatsheet for Phabricator revisions

This revision should only contain the NotFound.vue page and its catch-all route — that's the task. Please strip out the unrelated changes (navbar logo rework, SubscribeForm restyling, logo.svg replacement, package-lock.json removals) into their own separate revisions. See inline comments for specific fixes needed on indentation and missing newlines.

That's a good idea, you can add it as low priority in Frontend and assign it to @Chenani-MohamedAmine

ieli (Eli Iguer)
User

Projects (7)
View All

Calendar

Today

Tomorrow

Saturday

User Details

Recent Activity
View All

Thu, Mar 12

Tue, Mar 10

Mon, Mar 9

Thu, Mar 5

Wed, Mar 4

Tue, Mar 3

Sat, Feb 28

Fri, Feb 27

Wed, Feb 25

Tue, Feb 24

Fri, Feb 20

Tue, Feb 17

Feb 16 2026

ieli (Eli Iguer)User

Projects (7)View All