In D612#9490, @alken-orin wrote:

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/159/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/159/console

Build has FAILED

Next step is to provide a configuration with:

• the mapping job/project
• emulate what we would need at Jenkins plugin level: only fire notifications on job failed

Rebased. More doc.

@Rashk0 any advice?

Summary of previous discussions

Submitted by Gaurav Arora at https://github.com/nasqueron/docker-phabricator/pull/4

Build is green https://ci.nasqueron.org/job/test-notifications-phab/158/ for more details.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/157/ for more details.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/156/ for more details.

Better code documentation

EOL

In D617#9435, @dereckson wrote:

There is an issue in logic code too.

[ErrorException]                           
Undefined property: stdClass::$repository

Payload was already a notification, not a DockerHub payload.

More tests.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/155/ for more details.

There is an issue in logic code too.

Rebased against master.

That would be set -e

There is no demonstrated advantage to use that, the json parsing issue in D347 was a false issue.

Build is green https://ci.nasqueron.org/job/test-auth-grove-phab/4/ for more details.

According Bradipo from Freenode tcl channel, parsing is okay (and produces a correct dict) with json 1.3.3.

JSON makes a lot of sense, there is no need to parse twice a JSON payload, once for our notification format, once for the source payload.