Details

Reviewers

Maniphest Tasks

T1724: Split Docker engines between production (docker-001) and dev (dwellers)

Commits

rOPS1abc93e26ee5: Update Docker socket ownership

Summary

In D2668, the group name allowed to connect to Docker socket is customized.
Yet, on Dwellers, the docker client still can't connect on it.

There is a similar known issue reported upstream, which suggests the socket
systemd unit used for socket-activated services also needs to be aware
of the group.

References:

Ref T1724

Test Plan

docker ps on Dwellers

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Passed

Unit

No Test Coverage

Branch

docker_add_config

Build Status

Buildable 4192
Build 4444: arc lint + arc unit

Event Timeline

DorianWinty requested review of this revision.Apr 15 2022, 16:08

DorianWinty created this revision.

Harbormaster completed remote builds in B4187: Diff 6745.Apr 15 2022, 16:08

dereckson edited the summary of this revision. (Show Details)Apr 15 2022, 17:36

dereckson edited the test plan for this revision. (Show Details)

dereckson requested changes to this revision.Apr 15 2022, 17:58

dereckson added inline comments.

roles/paas-docker/devel/config.sls
1	Header is missing
roles/paas-docker/devel/files/socket.conf
2	A lot is missing. Read 4 or 5 other roles//files/ files to have an idea of the medata we put there.

This revision now requires changes to proceed.Apr 15 2022, 17:58

It currently fails:

Complector

$ salt dwellers state.sls roles/paas-docker/devel/config   (git)-[dwellers-dev] 
dwellers:
----------
          ID: /etc/systemd/system/docker.socket.d/socket.conf
    Function: file.managed
      Result: False
     Comment: Source file salt://role/pass-docker/devel/files/socket.conf not found in saltenv 'base'
     Started: 17:59:49.455264
    Duration: 52.343 ms
     Changes:   

Summary for dwellers
------------
Succeeded: 0
Failed:    1
------------
Total states run:     1
Total run time:  52.343 ms

dereckson added inline comments.Apr 15 2022, 18:04

roles/paas-docker/devel/config.sls
3	See the test run in comment, path is wrong. Pro tip: `git status` or `git whatchanged`, copy/paste from there (or in IDE like Atom right click, copy project path).

dereckson retitled this revision from Fix issue about connexion on docker dev to Fix issue about connection on docker dev.Apr 15 2022, 18:23

dereckson added inline comments.Apr 15 2022, 18:29

roles/paas-docker/devel/config.sls
4	Also I tested with updated path that gives that: dwellers: ID: /etc/systemd/system/docker.socket.d/socket.conf Function: file.managed Result: False Comment: Parent directory not present Started: 18:25:30.559029 Duration: 76.699 ms Changes:

dereckson added inline comments.Apr 15 2022, 18:31

roles/paas-docker/devel/files/socket.conf
9	That doesn't work either: systemd options are sorted by categories: [category] key=value Look on the upstream issue or on the systemd documentation the category for that one.